Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use Umbrella Imports #27

Merged
merged 2 commits into from
Dec 18, 2023
Merged

fix: Use Umbrella Imports #27

merged 2 commits into from
Dec 18, 2023

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • MPIHasher was updated to a Swift class which required the umbrella header to imported rather than the old public header when not doing the module import. The majority of kits don't use MPIHasher so they aren't affected though we have created tickets to update them in the future.

Testing Plan

  • Confirmed compilation and build then manually tested MPIHasher functionality once imported correctly

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Dec 6, 2023
einsteinx2
einsteinx2 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested this solution locally myself)

@BrandonStalnaker BrandonStalnaker merged commit 278c7a2 into development Dec 18, 2023
3 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/6099-Use-Umbrella-Imports-For-Kits branch December 18, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdozor samdozor samdozor approved these changes

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrandonStalnaker @einsteinx2 @samdozor